add sameShape constraint kind #103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://129338238
|
@swift-ci Please test |
This was referenced Sep 15, 2025
d-ronnqvist
approved these changes
Sep 15, 2025
|
For completeness, in case anyone is watching just this PR, i'm holding off merging this one until swiftlang/swift-docc#1290 is fully approved, since merging this will break DocC's build otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://129338238, resolves #97
Summary
This PR adds a
sameShapekind toSymbolGraph.Symbol.Swift.GenericConstraint.Kind, used in situations where parameter packs need to be of the same "shape" (usually length, but also sometimes used for type similarities too, from what i can tell).Dependencies
This will break Swift-DocC's build, and requires a separate PR there to avoid breaking the toolchain build: swiftlang/swift-docc#1290
Testing
End-to-end testing requires the matching Swift-DocC PR, so testing instructions here are limited to unit tests.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded